dev/qmk_firmware
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Fix indicator issue

Browse source
This commit is contained in:
lokher 2022-08-26 09:48:51 +08:00
parent 6829fbd074
commit 652e6f3db8
1 changed files with 17 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
keyboards/keychron/bluetooth/indicator.c
View file

@ -213,8 +213,9 @@ static void indicator_timer_cb(void *arg) {
if ((indicator_config.duration == 0 || indicator_config.elapsed <= indicator_config.duration) && next_period != 0) {
indicator_config.elapsed += next_period;
} else
} else {
time_up = true;
}
}
break;
default:
@ -224,6 +225,21 @@ static void indicator_timer_cb(void *arg) {
break;
}
#ifdef HOST_LED_PIN_LIST
if (indicator_config.value)
{
uint8_t idx = (indicator_config.value & 0x0F) - 1;
if (idx < HOST_DEVICES_COUNT) {
if ((indicator_config.value & 0x80) && !time_up) {
writePin(host_led_pin_list[idx], HOST_LED_PIN_ON_STATE);
} else {
writePin(host_led_pin_list[idx], !HOST_LED_PIN_ON_STATE);
}
}
}
#endif
if (time_up) {
/* Set indicator to off on timeup, avoid keeping light up until next update in raindrop effect */
indicator_config.value = indicator_config.value & 0x0F;
@ -236,20 +252,6 @@ static void indicator_timer_cb(void *arg) {
indicator_config.value = 0;
}
#ifdef HOST_LED_PIN_LIST
if (indicator_config.value)
{
uint8_t idx = (indicator_config.value & 0x0F) - 1;
chDbgAssert(idx < HOST_DEVICES_COUNT, "array out of bounds");
if (indicator_config.value & 0x80) {
writePin(host_led_pin_list[idx], HOST_LED_PIN_ON_STATE);
} else {
writePin(host_led_pin_list[idx], !HOST_LED_PIN_ON_STATE);
}
}
#endif
if (indicator_config.value == 0 && !indicator_is_backlit_enabled_eeprom()) {
indicator_disable();
}